Re: [RFC PATCH net-next 2/3] net: dsa: move switchdev event implementation under the same switch/case statement

From: Florian Fainelli
Date: Tue Nov 10 2020 - 22:45:05 EST




On 11/8/2020 5:19 AM, Vladimir Oltean wrote:
> We'll need to start listening to SWITCHDEV_FDB_{ADD,DEL}_TO_DEVICE
> events even for interfaces where dsa_slave_dev_check returns false, so
> we need that check inside the switch-case statement for SWITCHDEV_FDB_*.
>
> This movement also avoids two useless allocation / free paths for
> switchdev_work, which were difficult to avoid before, due to the code's
> structure:
> - on the untreated "default event" case.
> - on the case where fdb_info->added_by_user is false.
>
> Signed-off-by: Vladimir Oltean <olteanv@xxxxxxxxx>

Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
--
Florian