Re: [PATCH 4.19 48/71] of: Fix reserved-memory overlap detection

From: Vincent Whitchurch
Date: Wed Nov 11 2020 - 09:34:49 EST


On Wed, Nov 11, 2020 at 01:53:59PM +0100, Pavel Machek wrote:
> > OF: reserved mem: OVERLAP DETECTED!
> > bar@0 (0x00000000--0x00001000) overlaps with foo@0 (0x00000000--0x00002000)
> > OF: reserved mem: OVERLAP DETECTED!
> > foo@0 (0x00000000--0x00002000) overlaps with baz@1000 (0x00001000--0x00002000)
>
> Is it good idea to push this into 4.19 so early? It does not fix
> anything, it just causes warnings.
>
> Such overlap currently exists in 4.19:
>
> arch/arm/boot/dts/s5pv210.dtsi and can not be fixed easily, see:
>
> > > > > > clocks: clock-controller@e0100000 {
> > > > > > + compatible = "samsung,s5pv210-clock";
> > > > > > reg = <0xe0100000 0x10000>;
> > > > > ...
> > > > > > + pmu_syscon: syscon@e0108000 {
> > > > > > + reg = <0xe0108000 0x8000>;
> > > > > > };

The patch only concerns detection of overlaps in reserved-memory nodes,
and the above does not look like reserved-memory so it will not be
affected.

That being said, I already questioned the need for backporting this
patch:

https://lore.kernel.org/lkml/20201103111110.lvapcdf4nndunsie@xxxxxxxx/