Re: [PATCH 0/4] ARM: dts: aspeed: Add Facebook Galaxy100 BMC

From: Tao Ren
Date: Wed Nov 11 2020 - 20:39:23 EST


On Wed, Nov 11, 2020 at 11:34:10PM +0000, Joel Stanley wrote:
> On Wed, 11 Nov 2020 at 23:23, <rentao.bupt@xxxxxxxxx> wrote:
> >
> > From: Tao Ren <rentao.bupt@xxxxxxxxx>
> >
> > The patch series adds the initial version of device tree for Facebook
> > Galaxy100 (AST2400) BMC.
> >
> > Patch #1 adds common dtsi to minimize duplicated device entries across
> > Facebook Network AST2400 BMC device trees.
> >
> > Patch #2 simplfies Wedge40 device tree by using the common dtsi.
> >
> > Patch #3 simplfies Wedge100 device tree by using the common dtsi.
> >
> > Patch #4 adds the initial version of device tree for Facebook Galaxy100
> > BMC.
>
> Nice. They look good to me.
>
> Reviewed-by: Joel Stanley <joel@xxxxxxxxx>

Thanks a lot for the quick review, Joel.

> Is there another person familiar with the design you would like to
> review before I merge?

Patrick Williams sometimes helps reviewing my patches although he doesn't
work on Network BMCs. Let me see if he has bandwidth this time :)


Cheers,

Tao