Re: [PATCH] arm64: Change the location of DISCARDS

From: Catalin Marinas
Date: Thu Nov 12 2020 - 08:17:48 EST


On Fri, Nov 06, 2020 at 09:07:38AM +0000, Will Deacon wrote:
> On Fri, Nov 06, 2020 at 09:06:42AM +0800, tangyouling wrote:
> > In the include/asm-generic/vmlinux.lds.h:978, the description is as follows:
> > DISCARDS must be the last of output section definitions so that such archs
> > put those in earlier section definitions.
>
> Sure, I see that text, but I don't get why it matters. It would be nice to
> have some rationale as to what could go wrong if they aren't at the end,
> so we can improve that comment and avoid the inevitable regression in the
> future when things get shuffled around.

Maybe on other architectures or some old toolchains made a difference in
the resulting binary image size. It doesn't seem to be the case for
arm64.

--
Catalin