RE: [PATCH] platform/x86: dell-privacy: Add support for new privacy driver

[Limonciello, Mario]

> >
> > Again, if anything in this flow doesn't happen HW mic mute is still
> activated,
> > just will take longer (for duration of timeout) and have popping noise.
> 
> Thank you, can we put this in a comment in the driver please ?

Yes, I agree.  I suggested to Perry that his next submission of this driver
needs a lot more context in commit message (and it sounds like probably
code comments too).

> 
> I guess this also means that the led_class device is just there to
> catch the ledtrig_audio_set() call so that dell-firmware can tell the
> EC that the sw-mute is done and that it can move ahead with the hw-mute.
> 
> While the real, physical LED is fully under hardware control, right ?
> 
> That should probably also be in the same comment in the driver
> (feel free to re-use part of my wording for that if that helps).
> 
> Regards,
> 
> Hans

Yes - exactly.