Re: [PATCH net/next] net: ipconfig: Avoid spurious blank lines in boot log

From: Jakub Kicinski
Date: Thu Nov 12 2020 - 17:55:25 EST


On Tue, 10 Nov 2020 08:37:57 +0100 Thierry Reding wrote:
> From: Thierry Reding <treding@xxxxxxxxxx>
>
> When dumping the name and NTP servers advertised by DHCP, a blank line
> is emitted if either of the lists is empty. This can lead to confusing
> issues such as the blank line getting flagged as warning. This happens
> because the blank line is the result of pr_cont("\n") and that may see
> its level corrupted by some other driver concurrently writing to the
> console.
>
> Fix this by making sure that the terminating newline is only emitted
> if at least one entry in the lists was printed before.
>
> Reported-by: Jon Hunter <jonathanh@xxxxxxxxxx>
> Signed-off-by: Thierry Reding <treding@xxxxxxxxxx>

Applied, thanks!