Re: [PATCH] sched/fair: Fix overutilized update in enqueue_task_fair()

From: Peter Zijlstra
Date: Fri Nov 13 2020 - 03:18:35 EST


On Thu, Nov 12, 2020 at 11:12:01AM +0000, Quentin Perret wrote:
> enqueue_task_fair() attempts to skip the overutilized update for new
> tasks as their util_avg is not accurate yet. However, the flag we check
> to do so is overwritten earlier on in the function, which makes the
> condition pretty much a nop.
>
> Fix this by saving the flag early on.
>
> Fixes: 2802bf3cd936 ("sched/fair: Add over-utilization/tipping point
> indicator")

Fix that wrapping for you :-)

> Reported-by: Rick Yiu <rickyiu@xxxxxxxxxx>
> Signed-off-by: Quentin Perret <qperret@xxxxxxxxxx>

Thanks!