Re: [PATCH v2] mfd: kempld-core: Check for DMI definition before ACPI

From: Lee Jones
Date: Fri Nov 13 2020 - 05:15:01 EST


On Tue, 10 Nov 2020, Guenter Roeck wrote:

> On Tue, Nov 10, 2020 at 03:23:21PM +0000, Michael Brunner wrote:
> > Change the detection order to priorize DMI table entries over available
> > ACPI entries.
> >
> > This makes it more easy for product developers to patch product specific
> > handling into the driver.
> > Furthermore it allows to simplify the implementation a bit and
> > especially to remove the need to force synchronous probing.
> >
> > Based on the following commit introduced with v5.10-rc1:
> > commit e8299c7313af ("mfd: Add ACPI support to Kontron PLD driver")
> >
> > v2: Fixed coding style as suggested by Guenther Roeck
> >
>
> Nit: change logs should be after '---'.

Right. Please submit a v3 fixing this.

> Other than that,
>
> Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog