Re: [PATCH v9 30/44] arm64: kasan: Allow enabling in-kernel MTE

[Catalin Marinas]

On Fri, Nov 13, 2020 at 11:17:15AM +0000, Vincenzo Frascino wrote:
> On 11/12/20 9:43 AM, Catalin Marinas wrote:
> > On Tue, Nov 10, 2020 at 11:10:27PM +0100, Andrey Konovalov wrote:
> >> From: Vincenzo Frascino <vincenzo.frascino@xxxxxxx>
> >>
> >> Hardware tag-based KASAN relies on Memory Tagging Extension (MTE)
> >> feature and requires it to be enabled. MTE supports
> >>
> >> This patch adds a new mte_init_tags() helper, that enables MTE in
> >> Synchronous mode in EL1 and is intended to be called from KASAN runtime
> >> during initialization.
> > 
> > There's no mte_init_tags() in this function.
> 
> During the rework, I realized that the description of mte_init_tags() in this
> patch refers to mte_enable_kernel(). In fact the only thing that mte_init_tags()
> does is to configure the GCR_EL1 register, hence my preference would be to keep
> all the code that deals with such a register in one patch.

Fine by me as long as the commit text is consistent with the diff.

-- 
Catalin