Re: [PATCH v9 2/3] scsi: storvsc: Use vmbus_requestor to generate transaction IDs for VMBus hardening

[Wei Liu]

On Fri, Nov 13, 2020 at 11:33:27AM +0000, Wei Liu wrote:
> On Mon, Nov 09, 2020 at 11:04:01AM +0100, Andrea Parri (Microsoft) wrote:
> > From: Andres Beltran <lkmlabelt@xxxxxxxxx>
> > 
> > Currently, pointers to guest memory are passed to Hyper-V as
> > transaction IDs in storvsc. In the face of errors or malicious
> > behavior in Hyper-V, storvsc should not expose or trust the transaction
> > IDs returned by Hyper-V to be valid guest memory addresses. Instead,
> > use small integers generated by vmbus_requestor as requests
> > (transaction) IDs.
> > 
> > Signed-off-by: Andres Beltran <lkmlabelt@xxxxxxxxx>
> > Co-developed-by: Andrea Parri (Microsoft) <parri.andrea@xxxxxxxxx>
> > Signed-off-by: Andrea Parri (Microsoft) <parri.andrea@xxxxxxxxx>
> > Reviewed-by: Michael Kelley <mikelley@xxxxxxxxxxxxx>
> > Cc: "James E.J. Bottomley" <jejb@xxxxxxxxxxxxx>
> > Cc: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
> > Cc: linux-scsi@xxxxxxxxxxxxxxx
> 
> Reviewed-by: Wei Liu <wl@xxxxxxx>

Martin already gave his ack back in July. I guess nothing substantial
changed so it should have been carried over?

Wei.