Re: [PATCH] perf/x86: fix sysfs type mismatches

From: Kees Cook
Date: Fri Nov 13 2020 - 13:59:08 EST


On Fri, Nov 13, 2020 at 10:31:26AM -0800, Sami Tolvanen wrote:
> This change switches rapl to use PMU_FORMAT_ATTR, and fixes two other
> macros to use device_attribute instead of kobj_attribute to avoid
> callback type mismatches that trip indirect call checking with Clang's
> Control-Flow Integrity (CFI).
>
> Reported-by: Sedat Dilek <sedat.dilek@xxxxxxxxx>
> Signed-off-by: Sami Tolvanen <samitolvanen@xxxxxxxxxx>

Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>

--
Kees Cook