Re: [PATCH v4 08/16] iomap: Use mapping_seek_hole_data

From: Christoph Hellwig
Date: Sat Nov 14 2020 - 05:06:53 EST


On Thu, Nov 12, 2020 at 09:26:33PM +0000, Matthew Wilcox (Oracle) wrote:
> Enhance mapping_seek_hole_data() to handle partially uptodate pages and
> convert the iomap seek code to call it.

Maybe split this into two patches for the mapping_seek_hole_data
enhancement (which could use a little more of a commit log anyway..)
and the iomap switch?

> -static inline bool page_seek_match(struct page *page, bool seek_data)
> +static inline loff_t page_seek_hole_data(struct xa_state *xas,
> + struct address_space *mapping, struct page *page,
> + loff_t start, loff_t end, bool seek_data)

This seems like quite a huge function to force inline..