Re: [PATCH v4 06/16] mm/filemap: Add helper for finding pages

From: Matthew Wilcox
Date: Sat Nov 14 2020 - 10:16:57 EST


On Sat, Nov 14, 2020 at 11:03:18AM +0100, Christoph Hellwig wrote:
> On Thu, Nov 12, 2020 at 09:26:31PM +0000, Matthew Wilcox (Oracle) wrote:
> > + if (mark == XA_PRESENT)
> > + page = xas_find(xas, max);
> > + else
> > + page = xas_find_marked(xas, max, mark);
>
> Is there any good reason xas_find_marked can't handle the XA_PRESENT
> case as well?

I've been thinking about making that change. It's a little trickier
than I thought it would be, so it's on the back burner for now.