drivers/net/wireless/ath/ath10k/sdio.c:2234:2: warning: Non-boolean value returned from function returning bool

From: kernel test robot
Date: Mon Nov 16 2020 - 00:56:28 EST


tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: f01c30de86f1047e9bae1b1b1417b0ce8dcd15b1
commit: 3c45f21af84eb05a355919abc80cf70a3a681cee ath10k: sdio: add firmware coredump support
compiler: nios2-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <rong.a.chen@xxxxxxxxx>


cppcheck possible warnings: (new ones prefixed by >>, may not real problems)

>> drivers/net/wireless/ath/ath10k/sdio.c:2234:2: warning: Non-boolean value returned from function returning bool [returnNonBoolInBooleanFunction]
return param & HI_OPTION_SDIO_CRASH_DUMP_ENHANCEMENT_FW;
^

vim +2234 drivers/net/wireless/ath/ath10k/sdio.c

3c45f21af84eb05 Wen Gong 2020-08-18 2225
3c45f21af84eb05 Wen Gong 2020-08-18 2226 static bool ath10k_sdio_is_fast_dump_supported(struct ath10k *ar)
3c45f21af84eb05 Wen Gong 2020-08-18 2227 {
3c45f21af84eb05 Wen Gong 2020-08-18 2228 u32 param;
3c45f21af84eb05 Wen Gong 2020-08-18 2229
3c45f21af84eb05 Wen Gong 2020-08-18 2230 ath10k_sdio_read_host_interest_value(ar, HI_ITEM(hi_option_flag2), &param);
3c45f21af84eb05 Wen Gong 2020-08-18 2231
3c45f21af84eb05 Wen Gong 2020-08-18 2232 ath10k_dbg(ar, ATH10K_DBG_SDIO, "sdio hi_option_flag2 %x\n", param);
3c45f21af84eb05 Wen Gong 2020-08-18 2233
3c45f21af84eb05 Wen Gong 2020-08-18 @2234 return param & HI_OPTION_SDIO_CRASH_DUMP_ENHANCEMENT_FW;
3c45f21af84eb05 Wen Gong 2020-08-18 2235 }
3c45f21af84eb05 Wen Gong 2020-08-18 2236

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx