Re: [PATCH][next] drm/atomic: avoid null pointer dereference on pointer crtc

From: Colin Ian King
Date: Mon Nov 16 2020 - 06:28:27 EST


On 16/11/2020 11:08, Simon Ser wrote:
> On Monday, November 16, 2020 12:03 PM, Colin King <colin.king@xxxxxxxxxxxxx> wrote:
>
>> From: Colin Ian King colin.king@xxxxxxxxxxxxx
>>
>> Since moving to the new debug helper functions we now have a debug message
>> that dereferences crtc to print a kernel debug message when crtc is null
>> and so this debug message will now cause a null pointer dereference. Since
>> this is a debug message it probably is just simplest to fix this by just
>> removing the debug message altogether.
>
> NACK. This removes the log altogether instead of fixing it.
>
> A fix has already been pushed to drm-misc-next: 0003b687ee6d ("drm: fix
> oops in drm_atomic_set_crtc_for_connector").
>
Good to see this has already been fixed. Thanks.

Colin