Re: [PATCH v4 14/27] completion: fix kernel-doc markups

From: Peter Zijlstra
Date: Mon Nov 16 2020 - 06:36:40 EST


On Mon, Nov 16, 2020 at 11:18:10AM +0100, Mauro Carvalho Chehab wrote:
> Kernel-doc only supports having the comment just before
> the identifier.
>
> The markup for init_completion is actually for
> __init_completion.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx>
>
> ---
>
> Thats said, IMHO, it would make sense to simply
> rename __init_completion() to init_completion() and drop
> this define:
>
> #define init_completion(x) __init_completion(x)

Yeah, that seems to be the result of much code shuffling. That cleanups
seems sanest.