Re: [PATCH] syscalls: Fix file comments for syscalls implemented in kernel/sys.c

From: Christoph Hellwig
Date: Mon Nov 16 2020 - 11:23:37 EST


On Thu, Nov 12, 2020 at 04:56:57PM -0500, Tal Zussman wrote:
> The relevant syscalls were previously moved from kernel/timer.c to kernel/sys.c,
> but the comments weren't updated to reflect this change.
>
> Fixing these comments messes up the alphabetical ordering of syscalls by
> filename. This could be fixed by merging the two groups of kernel/sys.c syscalls,
> but that would require reordering the syscalls and renumbering them to maintain
> the numerical order in unistd.h.

Lots of overly long lines in your commit log.

As for the patch itself: IMHO we should just remove the comments
about the files as that information is completely irrelevant.