Re: [PATCH v2] soc: ti: pruss: Fix wrong check against *get_match_data return value

From: santosh . shilimkar
Date: Mon Nov 16 2020 - 14:06:59 EST


On 11/16/20 9:31 AM, Suman Anna wrote:
Hi Santosh,

On 11/16/20 11:22 AM, Grzegorz Jaszczyk wrote:
Since the of_device_get_match_data() doesn't return error code, remove
wrong IS_ERR test. Proper check against NULL pointer is already done
later before usage: if (data && data->...).

Additionally, proceeding with empty device data is valid (e.g. in case
of "ti,am3356-pruss").

Fixes: ba59c9b43c86 ("soc: ti: pruss: support CORECLK_MUX and IEPCLK_MUX")
Reported-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
Signed-off-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@xxxxxxxxxx>
Acked-by: Suman Anna <s-anna@xxxxxx>

Can you please pick this up for 5.10-rc's?

Nothing is broken so I will just add these for next merge window.

Regards,
Santosh