Re: [PATCH] KVM: SVM: check CR4 changes against vcpu->arch

From: Jim Mattson
Date: Mon Nov 16 2020 - 17:20:49 EST


On Mon, Nov 16, 2020 at 10:11 AM Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote:
>
> Similarly to what vmx/vmx.c does, use vcpu->arch.cr4 to check if CR4
> bits PGE, PKE and OSXSAVE have changed. When switching between VMCB01
> and VMCB02, CPUID has to be adjusted every time if CR4.PKE or CR4.OSXSAVE
> change; without this patch, instead, CR4 would be checked against the
> previous value for L2 on vmentry, and against the previous value for
> L1 on vmexit, and CPUID would not be updated.
>
> Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>
Reviewed-by: Jim Mattson <jmattson@xxxxxxxxxx>