[PATCH v2] ttyprintk: optimize tpk_close flush code

From: Junyong Sun
Date: Mon Nov 16 2020 - 21:21:16 EST


tpk_printk(NULL,0) do nothing but call tpk_flush to
flush buffer, so why don't use tpk_flush diretcly?
this is a small optimization.

Signed-off-by: Junyong Sun <sunjunyong@xxxxxxxxxx>
---
changes in v2:
- rm the flush comment as tpk_flush makes it obvious.
---
---
drivers/char/ttyprintk.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/char/ttyprintk.c b/drivers/char/ttyprintk.c
index 6a0059e..1f82742 100644
--- a/drivers/char/ttyprintk.c
+++ b/drivers/char/ttyprintk.c
@@ -103,8 +103,7 @@ static void tpk_close(struct tty_struct *tty, struct file *filp)
unsigned long flags;

spin_lock_irqsave(&tpkp->spinlock, flags);
- /* flush tpk_printk buffer */
- tpk_printk(NULL, 0);
+ tpk_flush();
spin_unlock_irqrestore(&tpkp->spinlock, flags);

tty_port_close(&tpkp->port, tty, filp);
--
2.7.4