Re: [PATCH v2 4/8] usb: typec: Remove one bit support for the Thunderbolt rounded/non-rounded cable

From: Heikki Krogerus
Date: Tue Nov 17 2020 - 05:46:50 EST


On Fri, Nov 13, 2020 at 12:24:59PM -0800, Utkarsh Patel wrote:
> Two bits support for the Thunderbolt rounded/non-rounded cable has been
> added to the header file.
> Hence, removing unused TBT_CABLE_ROUNDED definition from the header file.
>
> Signed-off-by: Utkarsh Patel <utkarsh.h.patel@xxxxxxxxx>

Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>

> --
> changes in v2:
> - Removed the fixes tag as there is no functional implication.
> --
> ---
> include/linux/usb/typec_tbt.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/usb/typec_tbt.h b/include/linux/usb/typec_tbt.h
> index aad648d14bb3..63dd44b72e0c 100644
> --- a/include/linux/usb/typec_tbt.h
> +++ b/include/linux/usb/typec_tbt.h
> @@ -39,7 +39,6 @@ struct typec_thunderbolt_data {
> #define TBT_CABLE_USB3_GEN1 1
> #define TBT_CABLE_USB3_PASSIVE 2
> #define TBT_CABLE_10_AND_20GBPS 3
> -#define TBT_CABLE_ROUNDED BIT(19)
> #define TBT_CABLE_ROUNDED_SUPPORT(_vdo_) \
> (((_vdo_) & GENMASK(20, 19)) >> 19)
> #define TBT_GEN3_NON_ROUNDED 0
> --
> 2.17.1

thanks,

--
heikki