Re: [PATCH 1/1] ACPI/nfit: avoid accessing uninitialized memory in acpi_nfit_ctl()

From: Dan Williams
Date: Wed Nov 18 2020 - 03:08:40 EST


On Tue, Nov 17, 2020 at 11:36 PM Zhen Lei <thunder.leizhen@xxxxxxxxxx> wrote:
>
> The ACPI_ALLOCATE() does not zero the "buf", so when the condition
> "integer->type != ACPI_TYPE_INTEGER" in int_to_buf() is met, the result
> is unpredictable in acpi_nfit_ctl().
>
> Signed-off-by: Zhen Lei <thunder.leizhen@xxxxxxxxxx>

Looks good to me.

Reviewed-by: Dan Williams <dan.j.williams@xxxxxxxxx>

I'll pick this up.