Re: [PATCH v2] drm/imx: depend on COMMON_CLK to fix compile tests

From: Philipp Zabel
Date: Wed Nov 18 2020 - 09:55:23 EST


Hi Krzysztof,

On Tue, 2020-11-17 at 19:24 +0100, Krzysztof Kozlowski wrote:
> The iMX DRM LVDS driver uses Common Clock Framework thus it cannot be
> built on platforms without it (e.g. compile test on MIPS with RALINK and
> SOC_RT305X):
>
> /usr/bin/mips-linux-gnu-ld: drivers/gpu/drm/imx/imx-ldb.o: in function `imx_ldb_encoder_disable':
> imx-ldb.c:(.text+0x400): undefined reference to `clk_set_parent'
>
> Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
>
> ---
>
> Changes since v1:
> 1. Put depends in DRM_IMX_LDB option only.
> ---
> drivers/gpu/drm/imx/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/imx/Kconfig b/drivers/gpu/drm/imx/Kconfig
> index 6231048aa5aa..73fe2bc5633c 100644
> --- a/drivers/gpu/drm/imx/Kconfig
> +++ b/drivers/gpu/drm/imx/Kconfig
> @@ -28,6 +28,7 @@ config DRM_IMX_TVE
> config DRM_IMX_LDB
> tristate "Support for LVDS displays"
> depends on DRM_IMX && MFD_SYSCON
> + depends on COMMON_CLK
> select DRM_PANEL
> help
> Choose this to enable the internal LVDS Display Bridge (LDB)

Thank you, applied to imx-drm/next.

regards
Philipp