Re: [PATCH 2/2] hwspinlock: add sunxi hardware spinlock support

From: Maxime Ripard
Date: Wed Nov 18 2020 - 10:38:00 EST


Hi Wilken,

On Wed, Nov 18, 2020 at 11:02:40AM +0100, Wilken Gottwalt wrote:
> Adds the sunxi_hwspinlock driver and updates makefiles/maintainers.
>
> Signed-off-by: Wilken Gottwalt <wilken.gottwalt@xxxxxxxxxx>

A more descriptive commit log would be welcome here, for example
containing on which SoC this driver can be used, and on which it was
tested.

This is the third attempt at that driver, and you can find the previous
versions here:
https://patchwork.kernel.org/project/linux-arm-kernel/cover/20200210170143.20007-1-nborisov@xxxxxxxx/
https://lore.kernel.org/patchwork/patch/706512/

Most of the comments on those series still apply to yours.

Most importantly, this hwspinlock is used to synchronize the ARM cores
and the ARISC. How did you test this driver?

Thanks!
Maxime

Attachment: signature.asc
Description: PGP signature