Re: md: dm-writeback: add __noreturn to BUG-ging function

From: Randy Dunlap
Date: Wed Nov 18 2020 - 11:38:57 EST


On 11/18/20 8:35 AM, Christian Borntraeger wrote:
>
>
> On 18.11.20 17:07, Mike Snitzer wrote:
>> On Wed, Nov 18 2020 at 10:49am -0500,
>> Mike Snitzer <snitzer@xxxxxxxxxx> wrote:
>>
>>> I don't think my suggestion will help.. given it'd still leave
>>> persistent_memory_claim() without a return statement.
>>>
>>> Think it worthwhile to just add a dummy 'return 0;' after the BUG().
>>
>> Decided to go with this, now staged for 5.11:
>> https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-5.11&id=a1e4865b4dda7071f3707f7e551289ead66e38b1
>>
>
> Looks like a sane solution. Thank you for following up.

Yes, thanks again.

--
~Randy