Re: [PATCH v3 2/3] fscrypt: Have filesystems handle their d_ops

From: Eric Biggers
Date: Wed Nov 18 2020 - 13:33:52 EST


On Wed, Nov 18, 2020 at 06:42:44AM +0000, Daniel Rosenberg wrote:
> diff --git a/fs/crypto/fname.c b/fs/crypto/fname.c
> index 1fbe6c24d705..cb3cfa6329ba 100644
> --- a/fs/crypto/fname.c
> +++ b/fs/crypto/fname.c
> @@ -570,7 +570,3 @@ int fscrypt_d_revalidate(struct dentry *dentry, unsigned int flags)
> return valid;
> }
> EXPORT_SYMBOL_GPL(fscrypt_d_revalidate);
> -
> -const struct dentry_operations fscrypt_d_ops = {
> - .d_revalidate = fscrypt_d_revalidate,
> -};

The declaration of fscrypt_d_ops in fs/crypto/fscrypt_private.h should be
removed too.

Otherwise this patch looks good; feel free to add:

Acked-by: Eric Biggers <ebiggers@xxxxxxxxxx>

- Eric