Re: [PATCH 1/3] spi: fix resource leak for drivers without .remove callback

From: Mark Brown
Date: Thu Nov 19 2020 - 11:10:26 EST


On Thu, Nov 19, 2020 at 05:04:12PM +0100, Uwe Kleine-König wrote:
> On Thu, Nov 19, 2020 at 03:41:39PM +0000, Mark Brown wrote:
> > On Thu, Nov 19, 2020 at 04:35:40PM +0100, Uwe Kleine-König wrote:

> > > (Not sure this makes a difference in real life, are there drivers
> > > without a .probe callback?)

> > Your changelog seemed to say that it would make remove mandatory.

> No, that's not what the patch did. It made unconditional use of
> spi_drv_remove(), but an spi_driver without .remove() was still ok. I
> will reword to make this clearer.

Ah, OK - I hadn't read the patch closely as the description sounded
wrong.

Attachment: signature.asc
Description: PGP signature