Re: [PATCH v2] mm: hugetlb: fix type of delta parameter and related local variables in gather_surplus_pages()

From: Mike Kravetz
Date: Thu Nov 19 2020 - 13:34:58 EST


On 11/19/20 5:48 AM, Liu Xiang wrote:
> On 64-bit machine, delta variable in hugetlb_acct_memory() may be larger
> than 0xffffffff, but gather_surplus_pages() can only use the low 32-bit
> value now. So we need to fix type of delta parameter and related local
> variables in gather_surplus_pages().
>
> Reported-by: Ma Chenggong <ma.chenggong@xxxxxxxxxxxxxx>
> Signed-off-by: Liu Xiang <liu.xiang@xxxxxxxxxxxxxx>
> Signed-off-by: Pan Jiagen <pan.jiagen@xxxxxxxxxxxxxx>
>
> ---
> Changes in v2:
> as suggested by Mike, apply the same fix to the related local
> variables in gather_surplus_pages().
> ---
> ---
> mm/hugetlb.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)

Thank you,

Reviewed-by: Mike Kravetz <mike.kravetz@xxxxxxxxxx>

--
Mike Kravetz