Re: [PATCH 1/1] pci: pciehp: Handle MRL interrupts to enable slot for hotplug.

From: Bjorn Helgaas
Date: Thu Nov 19 2020 - 17:27:46 EST


Hi Ashok,

When you update this patch, can you run "git log --oneline
drivers/pci/hotplug/pciehp*" and make yours match? It is a severe
character defect of mine, but seeing subject lines that are obviously
different than the convention is a disincentive to look at the patch.

On Thu, Nov 19, 2020 at 02:08:07PM -0800, Raj, Ashok wrote:
> On Thu, Nov 19, 2020 at 08:51:20AM +0100, Lukas Wunner wrote:
> > Hi Ashok,
> >
> > my sincere apologies for the delay.
>
> No worries..
>
> >
> > On Fri, Sep 25, 2020 at 04:01:38PM -0700, Ashok Raj wrote:
> > > When Mechanical Retention Lock (MRL) is present, Linux doesn't process
> > > those change events.
> > >
> > > The following changes need to be enabled when MRL is present.
> > >
> > > 1. Subscribe to MRL change events in SlotControl.
> > > 2. When MRL is closed,
> > > - If there is no ATTN button, then POWER on the slot.
> > > - If there is ATTN button, and an MRL event pending, ignore
> > > Presence Detect. Since we want ATTN button to drive the
> > > hotplug event.