Re: [PATCH v6 16/17] RFC: kvm: pass kvm argument to follow_pfn callsites

[Paolo Bonzini]

On 20/11/20 16:44, Daniel Vetter wrote:
> > It's a bit of a pity, it's making an API more complex (the point of
> > gfn_to_pfn_memslot vs gfn_to_pfn is exactly that you don't need a
> > "struct kvm*" and it's clear that you've already done the lookup into
> > that struct kvm.
>
> Yeah I noticed that, I think pushing the lookups down should work, but
> that's a fairly large-scale change. I didn't want to do that for the
> RFC since it would distract from the actual change/goal.
> -Daniel

Pushing the lookups down would be worse code and possibly introduce 
TOC/TOU races, so better avoid that.  Your patch is fine. :)

Paolo