Re: [PATCH 03/27] blk-iocost: use local[64]_t for percpu stat
From: Tejun Heo
Date: Fri Nov 20 2020 - 17:14:45 EST
Hello,
On Sat, Nov 21, 2020 at 06:51:47AM +0900, Stafford Horne wrote:
> FYI, I am just noticing this but this breaks my allyesconfig build
> on OpenRISC; as 32-bit arch/openrisc doesn't define local64.h
>
> In general local64 is slow on 32-bit architectures, would that
> be a problem with the usage here? Are the calls to local64_*
> below on critical paths?
It gets hot when running on really high iops devices but that hopefully
isn't a problem for 32bit openrisc.
> Either way I will submit a patch in include generic local64.h
> on OpenRISC, I confirmed it fixes the build. I do not know of anyone
> using cgroups on OpenRISC systems.
Yeah, sounds like the right fix.
Thanks.
--
tejun