Re: [PATCH 1/1] mm: compaction: avoid fast_isolate_around() to set pageblock_skip on reserved pages

From: Andrea Arcangeli
Date: Sat Nov 21 2020 - 14:54:23 EST

Next message: kernel test robot: "drivers/soc/qcom/smsm.c:152:22: sparse: sparse: incorrect type in argument 1 (different address spaces)"
Previous message: kernel test robot: "sound/soc/intel/catpt/loader.c:654 catpt_first_boot_firmware() warn: consider using resource_size() here"
In reply to: Andrea Arcangeli: "[PATCH 1/1] mm: compaction: avoid fast_isolate_around() to set pageblock_skip on reserved pages"
Next in thread: David Hildenbrand: "Re: [PATCH 1/1] mm: compaction: avoid fast_isolate_around() to set pageblock_skip on reserved pages"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Sat, Nov 21, 2020 at 02:45:06PM -0500, Andrea Arcangeli wrote:
> + if (likely(!PageReserved(page)))

NOTE: this line will have to become "likely(page &&
!PageReserved(page))" to handle the case of non contiguous zones,
since pageblock_pfn_to_page might return NULL in that case.. I noticed
right after sending, but I'll wait some feedback before resending the
correction in case it gets fixed in another way.

Next message: kernel test robot: "drivers/soc/qcom/smsm.c:152:22: sparse: sparse: incorrect type in argument 1 (different address spaces)"
Previous message: kernel test robot: "sound/soc/intel/catpt/loader.c:654 catpt_first_boot_firmware() warn: consider using resource_size() here"
In reply to: Andrea Arcangeli: "[PATCH 1/1] mm: compaction: avoid fast_isolate_around() to set pageblock_skip on reserved pages"
Next in thread: David Hildenbrand: "Re: [PATCH 1/1] mm: compaction: avoid fast_isolate_around() to set pageblock_skip on reserved pages"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]