Re: [PATCH] compiler_attribute: remove CONFIG_ENABLE_MUST_CHECK

From: Miguel Ojeda
Date: Sat Nov 21 2020 - 15:51:11 EST


On Sat, Nov 21, 2020 at 8:44 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
>
> Our goal is to always enable __must_check where appreciate, so this
> CONFIG option is no longer needed.

This would be great. It also implies we can then move it to
`compiler_attributes.h` since it does not depend on config options
anymore.

We should also rename it to `__nodiscard`, since that is the
standardized name (coming soon to C2x and in C++ for years).

Cc'ing the Clang folks too to make them aware.

Cheers,
Miguel