Re: [RFC] MAINTAINERS tag for cleanup robot

From: Joe Perches
Date: Mon Nov 23 2020 - 00:23:31 EST


(removing almost all the cc: lists and leaving scsi and lkml)

On Sat, 2020-11-21 at 10:02 -0800, Joe Perches wrote:
> On Sat, 2020-11-21 at 09:18 -0800, James Bottomley wrote:
> > On Sat, 2020-11-21 at 08:50 -0800, trix@xxxxxxxxxx wrote:
> > > A difficult part of automating commits is composing the subsystem
> > > preamble in the commit log. For the ongoing effort of a fixer
> > > producing one or two fixes a release the use of 'treewide:' does
> > > not seem appropriate.
> > >
> > > It would be better if the normal prefix was used. Unfortunately
> > > normal is not consistent across the tree.
> > >
> > > D: Commit subsystem prefix
> > >
> > > ex/ for FPGA DFL DRIVERS
> > >
> > > D: fpga: dfl:
> >
> > I've got to bet this is going to cause more issues than it solves.
> > SCSI uses scsi: <driver>: for drivers but not every driver has a
> > MAINTAINERS entry. We use either scsi: or scsi: core: for mid layer
> > things, but we're not consistent. Block uses blk-<something>: for all
> > of it's stuff but almost no <somtehing>s have a MAINTAINERS entry. So
> > the next thing you're going to cause is an explosion of suggested
> > MAINTAINERs entries.
>
> As well as some changes require simultaneous changes across
> multiple subsystems.

Perhaps a start of this would be something like the below for a new
MAINTAINERS entry just for SCSI CORE.

This adds an "E:" patch prefix entry as well as a specific file
list for what seem to be "scsi core" files so that the generic
SCSI SUBSYSTEM F:drivers/scsi/ entry does not have to be used.

The SCSI SUBSYSTEM could have an E: entry of "scsi:" so that
driver specific content could be automatically prefixed with
"scsi: <basename(dirname)>:
---
MAINTAINERS | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 5f10105cac6f..68521abd1bd8 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -15631,6 +15631,24 @@ S: Maintained
W: http://www.kernel.dk
F: drivers/scsi/sr*

+SCSI CORE
+M: "James E.J. Bottomley" <jejb@xxxxxxxxxxxxx>
+M: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
+L: linux-scsi@xxxxxxxxxxxxxxx
+S: Maintained
+Q: https://patchwork.kernel.org/project/linux-scsi/list/
+T: git git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git
+T: git git://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git
+E: "scsi: core:"
+F: include/linux/scsi*
+F: drivers/scsi/constants.c
+F: drivers/scsi/hosts.c
+F: drivers/scsi/scsi.*
+F: drivers/scsi/scsi_*
+F: drivers/scsi/sd.c
+F: drivers/scsi/sense_codes.h
+F: drivers/scsi/sr.c
+
SCSI RDMA PROTOCOL (SRP) INITIATOR
M: Bart Van Assche <bvanassche@xxxxxxx>
L: linux-rdma@xxxxxxxxxxxxxxx