Re: [PATCH 030/141] ext2: Fix fall-through warnings for Clang

From: Jan Kara
Date: Mon Nov 23 2020 - 04:37:18 EST


On Fri 20-11-20 12:28:25, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> by explicitly adding a break statement instead of just letting the code
> fall through to the next case.
>
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>

Thanks. Applied.

Honza

> ---
> fs/ext2/inode.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c
> index 11c5c6fe75bb..78c417d3c898 100644
> --- a/fs/ext2/inode.c
> +++ b/fs/ext2/inode.c
> @@ -1256,6 +1256,7 @@ static void __ext2_truncate_blocks(struct inode *inode, loff_t offset)
> mark_inode_dirty(inode);
> ext2_free_branches(inode, &nr, &nr+1, 3);
> }
> + break;
> case EXT2_TIND_BLOCK:
> ;
> }
> --
> 2.27.0
>
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR