Re: [PATCH] arm64: update RANDOMIZE_MODULE_REGION_FULL config description

From: Will Deacon
Date: Mon Nov 23 2020 - 06:12:20 EST


On Sat, Nov 21, 2020 at 11:08:55PM -0800, youngjun wrote:
> module randomization is reduced. (range to 2 GB)
> RANDOMIZE_MODULE_REGION_FULL config description is not updated.
> update RANDOMIZE_MODULE_REGION_FULL config description.
>
> Signed-off-by: youngjun <her0gyugyu@xxxxxxxxx>
> ---
> arch/arm64/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

This looks like the same patch as the one I reviewed here:

https://lore.kernel.org/r/20201109112705.GC14356@willie-the-truck

but the commit message isn't a lot better. Please could you (or Ross)
post a version with a fixed commit message?

Thanks,

Will

> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 1515f6f153a0..0da551828a59 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -1804,11 +1804,11 @@ config RANDOMIZE_BASE
> If unsure, say N.
>
> config RANDOMIZE_MODULE_REGION_FULL
> - bool "Randomize the module region over a 4 GB range"
> + bool "Randomize the module region over a 2 GB range"
> depends on RANDOMIZE_BASE
> default y
> help
> - Randomizes the location of the module region inside a 4 GB window
> + Randomizes the location of the module region inside a 2 GB window
> covering the core kernel. This way, it is less likely for modules
> to leak information about the location of core kernel data structures
> but it does imply that function calls between modules and the core
> --
> 2.17.1
>