Re: [PATCH 1/2] events/core: introduce perf_pmu_disable_all() to turn off all PMU

From: Peter Zijlstra
Date: Mon Nov 23 2020 - 09:07:52 EST


On Mon, Nov 23, 2020 at 01:37:25PM +0800, Pingfan Liu wrote:

> +/* When crashed, other cpus hang in idle loop, so here do an emergency job under no lock */

-ENOPARSE, -ETOOLONG

> +void perf_pmu_disable_all(void)
> +{
> + struct pmu *pmu;
> +
> + list_for_each_entry(pmu, &pmus, entry)
> + if (pmu->pmu_disable)
> + pmu->pmu_disable(pmu);
> +}

This violates both locking rules and coding style.