Re: [PATCH v2] net: mvpp2: divide fifo for dts-active ports only

From: Jakub Kicinski
Date: Tue Nov 24 2020 - 18:08:00 EST


On Mon, 23 Nov 2020 20:17:15 +0000 Russell King - ARM Linux admin wrote:
> On Mon, Nov 23, 2020 at 07:54:33PM +0200, stefanc@xxxxxxxxxxx wrote:
> > From: Stefan Chulski <stefanc@xxxxxxxxxxx>
> >
> > Tx/Rx FIFO is a HW resource limited by total size, but shared
> > by all ports of same CP110 and impacting port-performance.
> > Do not divide the FIFO for ports which are not enabled in DTS,
> > so active ports could have more FIFO.
> > No change in FIFO allocation if all 3 ports on the communication
> > processor enabled in DTS.
> >
> > The active port mapping should be done in probe before FIFO-init.
> >
> > Signed-off-by: Stefan Chulski <stefanc@xxxxxxxxxxx>
>
> Thanks.
>
> Reviewed-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxx>
>
> One thing I didn't point out is that netdev would like patch submissions
> to indicate which tree they are targetting. Are you intending this for
> net or net-next?
>
> [PATCH net vX] ...
>
> or
>
> [PATCH net-next vX] ...
>
> in the subject line please.

I'll assume Stefan does not know :) This patches does not appear to
fix a bug or other user-visible issue, so applying to net-next, it
will be part of the next Linux release (5.11) and not queued to LTS.

Thanks!