Re: [net-next PATCH v5 1/4] net: dsa: mv88e6xxx: Don't force link when using in-band-status

[Andrew Lunn]

On Tue, Nov 24, 2020 at 05:34:37PM +1300, Chris Packham wrote:
> When a port is configured with 'managed = "in-band-status"' switch chips
> like the 88E6390 need to propagate the SERDES link state to the MAC
> because the link state is not correctly detected. This causes problems
> on the 88E6185/88E6097 where the link partner won't see link state
> changes because we're forcing the link.
> 
> To address this introduce a new device specific op port_sync_link() and
> push the logic from mv88e6xxx_mac_link_up() into that. Provide an
> implementation for the 88E6185 like devices which doesn't force the
> link.
> 
> Signed-off-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx>

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

    Andrew