RE: [PATCH] arm64: dts: freescale: sl28: correct MMC order

From: Y.b. Lu
Date: Tue Nov 24 2020 - 22:03:56 EST


> -----Original Message-----
> From: Michael Walle <michael@xxxxxxxx>
> Sent: Wednesday, November 25, 2020 5:21 AM
> To: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx
> Cc: Shawn Guo <shawnguo@xxxxxxxxxx>; Leo Li <leoyang.li@xxxxxxx>; Rob
> Herring <robh+dt@xxxxxxxxxx>; Y.b. Lu <yangbo.lu@xxxxxxx>; Vladimir
> Oltean <vladimir.oltean@xxxxxxx>; Michael Walle <michael@xxxxxxxx>
> Subject: [PATCH] arm64: dts: freescale: sl28: correct MMC order
>
> Commit 342ab37ecaf8 ("arm64: dts: freescale: use fixed index mmcN for
> layerscape") hardcoded the order of the MMC devices. This doesn't fit
> the sl28 boards, which come with an onboard eMMC. Thus use the more
> natural order for the eMMC and SD card. Use /dev/mmcblk0 for the eMMC
> and /dev/mmcblk1 for the SD card which is removable by the user.
>
> Please note, that the images for this board already use root=UUID=,
> therefore the actual device number doesn't matter for booting.
>
> Signed-off-by: Michael Walle <michael@xxxxxxxx>

It's ok for me to re-define mmc alias.
Reviewed-by: Yangbo Lu <yangbo.lu@xxxxxxx>

> ---
> arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> index fbaecf285d05..6da4a28c4d19 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> @@ -18,6 +18,8 @@
>
> aliases {
> crypto = &crypto;
> + mmc0 = &esdhc1;
> + mmc1 = &esdhc;
> serial0 = &duart0;
> serial1 = &duart1;
> serial2 = &lpuart1;
> --
> 2.20.1