RE: [char-misc-next 13/13] mei: virtio: virtualization frontend driver

From: Winkler, Tomas
Date: Wed Nov 25 2020 - 16:18:13 EST


>
> On Tue, Aug 18, 2020 at 02:51:47PM +0300, Tomas Winkler wrote:
> > +#ifndef VIRTIO_ID_MEI
> > +#define VIRTIO_ID_MEI 0xFFFE /* virtio mei */ #endif
>
> Just noticed now that this driver landed upstream. Can I ask that you guys
> please register IDs with the virtio TC and not just pick a number at random?
> In particular this is way outside allowed range.
>
> IDs should also be listed in include/uapi/linux/virtio_ids.h
>
> If people just pick random numbers like this collistions are unavoidable.
>
> List of IDs is part of virtio spec, chapter "Device Types".
>
> Please do this change now before this goes out to production!
Okay, this was assigned by ACRN, my impression was it's already registered.
Will take care of.
Thanks
Tomas