Re: [PATCH] riscv: defconfig: k210: Disable CONFIG_VT

From: Damien Le Moal
Date: Wed Nov 25 2020 - 20:59:53 EST


On Wed, 2020-11-25 at 13:47 +0100, Geert Uytterhoeven wrote:
> Hi Damien,
>
> On Wed, Nov 25, 2020 at 12:00 PM Damien Le Moal <Damien.LeMoal@xxxxxxx> wrote:
> > On 2020/11/25 18:26, Geert Uytterhoeven wrote:
> > > On Wed, Nov 25, 2020 at 10:02 AM Damien Le Moal <Damien.LeMoal@xxxxxxx> wrote:
> > > > On 2020/11/25 17:51, Geert Uytterhoeven wrote:
> > > > I was just fiddling with CONFIG_UNIX98_PTYS. Disabling it is OK with the simple
> > > > busybox userspace (no telnet/xterm like app running). But it saves only about
> > > > 1KB with my toolchain (gcc 9.3). So I left that one enabled. I am surprised that
> > > > you see 16K size impact... How big is your image ?
> > > >
> > > > For me, it is 1.768 MB right now for the sdcard defconfig, with CONFIG_VT
> > > > disabled and ext2 enabled.
> > >
> > > It might depend on how you measure. "size" says 15 KiB impact for UNIX98
> > > ptys, while bloat-o-meter reported less than 7 (my script uses "size").
> >
> > I look at the size of the arch/riscv/boot/loader.bin file since that is what
> > gets loaded in RAM and booted. It is significantly smaller than vmlinux file
> > size. E.g. for the sd card defconfig, I have:
> >
> > vmlinux: 2369920 B
> > loader.bin: 1751250 B
>
> Doesn't loader.bin lack bss?
> Bss does consume RAM, so you do want to take that into account, too.

Indeed. Good point. Thanks !

>
> Gr{oetje,eeting}s,
>
>                         Geert
>

--
Damien Le Moal
Western Digital