Re: [Intel-gfx] [drm/i915/gem] 59dd13ad31: phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second -54.0% regression
From: Chris Wilson
Date: Fri Nov 27 2020 - 08:08:17 EST
Quoting Xing Zhengjun (2020-11-27 01:51:41)
>
>
> On 11/27/2020 5:34 AM, Chris Wilson wrote:
> > Quoting Xing Zhengjun (2020-11-26 01:44:55)
> >>
> >>
> >> On 11/25/2020 4:47 AM, Chris Wilson wrote:
> >>> Quoting Oliver Sang (2020-11-19 07:20:18)
> >>>> On Fri, Nov 13, 2020 at 04:27:13PM +0200, Joonas Lahtinen wrote:
> >>>>> Hi,
> >>>>>
> >>>>> Could you add intel-gfx@xxxxxxxxxxxxxxxxxxxxx into reports going
> >>>>> forward.
> >>>>>
> >>>>> Quoting kernel test robot (2020-11-11 17:58:11)
> >>>>>>
> >>>>>> Greeting,
> >>>>>>
> >>>>>> FYI, we noticed a -54.0% regression of phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second due to commit:
> >>>>>
> >>>>> How many runs are there on the bad version to ensure the bisect is
> >>>>> repeatable?
> >>>>
> >>>> test 4 times.
> >>>> zxing@inn:/result/phoronix-test-suite/performance-true-Radial_Gradient_Paint-1024x1024-jxrendermark-1.2.4-ucode=0xd6-monitor=da39a3ee/lkp-cfl-d1/debian-x86_64-phoronix/x86_64-rhel-8.3/gcc-9/59dd13ad310793757e34afa489dd6fc8544fc3da$ grep -r "operations_per_second" */stats.json
> >>>> 0/stats.json: "phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second": 4133.487932,
> >>>> 1/stats.json: "phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second": 4120.421503,
> >>>> 2/stats.json: "phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second": 4188.414835,
> >>>> 3/stats.json: "phoronix-test-suite.jxrendermark.RadialGradientPaint.1024x1024.operations_per_second": 4068.549514,
> >>>
> >>> a w/o revert (drm-tip)
> >>> b w/ revert
> >>> +mB----------------------------------------------------------------------------+
> >>> | ..b |
> >>> | ..b.aa |
> >>> | ....a.a |
> >>> | ....a.a |
> >>> | b b ........a |
> >>> | b b b b......... a |
> >>> | b bb bbb........... |
> >>> |b ab bbab.bb.b............ba b a a ab a|
> >>> | |__A__| |
> >>> | |MA_| |
> >>> +------------------------------------------------------------------------------+
> >>> N Min Max Median Avg Stddev
> >>> a 120 3621.8761 7356.4442 4606.7895 4607.9132 156.17693
> >>> b 120 2664.0563 6359.9686 4519.5036 4534.4463 95.471121
> >>>
> >>> The patch is not expected to have any impact on the machine you are testing on.
> >>> -Chris
> >>>
> >>
> >> What's your code base?
> >> For my side:
> >> 1) sync the code to the head of Linux mainline
> >> 2) git reset --hard 59dd13ad31
> >> 3) git revert 59dd13ad3107
> >> We compare the test result of commit 59dd13ad3107 (step 2) and
> >> 2052847b06f8 (step 3, revert 59dd13ad3107), the regression should
> >> related with 59dd13ad3107. Each test case we run 5 times.
> >
> > a 59dd13ad31
> > b revert
> > +mB----------------------------------------------------------------------------+
> > | a |
> > | aa |
> > | .b....ba |
> > | .b....baa b |
> > | .........b . b b |
> > | a b.......... ..bb b b |
> > | b a b.............b.a b b |
> > |a a b. .aaa..b.............b..b....ab b a .|
> > | |__A__| |
> > | |___A_____| |
> > +------------------------------------------------------------------------------+
> > N Min Max Median Avg Stddev
> > a 120 3658.3435 6363.7812 4527.4406 4536.612 86.095459
> > b 120 3928.9643 6375.829 4576.0482 4585.4224 157.284
> >
>
> Could you share with me your test commands and the hardware info, then I
> can reproduce it on my side? Thanks.
It was a i7-8809G, identical i915 behaviour as the i7-8700 the report was
generated on.
sudo Xorg & for i in $(seq 1 120); do ./jx 13 1024 | awk '{print $1}' ; done
using -modesetting + iris (i965 makes no difference, just slightly
slower)
-Chris