Re: [RFC PATCH 2/3] net: sparx5: Add Sparx5 switchdev driver

From: Steen Hegelund
Date: Mon Nov 30 2020 - 09:31:33 EST


On 29.11.2020 11:30, Russell King - ARM Linux admin wrote:
EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

On Sun, Nov 29, 2020 at 10:52:45AM +0000, Russell King - ARM Linux admin wrote:
There are other issues too.

This is also wrong:

+ if (port->ndev && port->ndev->phydev)
+ status->link = port->ndev->phydev->link;

phylink already deals with that situation.

So if I need the link state, what interface should I then use to get it?


--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

Thanks for your comments


BR
Steen

---------------------------------------
Steen Hegelund
steen.hegelund@xxxxxxxxxxxxx