Re: [PATCH -v6 2/3] NOT kernel/man-pages man2/set_mempolicy.2: Add mode flag MPOL_F_NUMA_BALANCING

[Huang, Ying]

Dave Hansen <dave.hansen@xxxxxxxxx> writes:

> On 11/25/20 9:32 PM, Huang Ying wrote:
>> --- a/man2/set_mempolicy.2
>> +++ b/man2/set_mempolicy.2
>> @@ -113,6 +113,11 @@ A nonempty
>>  .I nodemask
>>  specifies node IDs that are relative to the set of
>>  node IDs allowed by the process's current cpuset.
>> +.TP
>> +.BR MPOL_F_NUMA_BALANCING " (since Linux 5.11)"
>> +Enable the Linux kernel NUMA balancing for the task if it is supported
>> +by kernel.  If the flag isn't supported by Linux kernel, return -1 and
>> +errno is set to EINVAL.
>
> The one thing I learned about manpage CodingStyle is that new sentences
> go on new lines.  I think this needs to be:
>
> .TP
> .BR MPOL_F_NUMA_BALANCING " (since Linux 5.11)"
> Enable the Linux kernel NUMA balancing for the task if it is supported
> by kernel.
> If the flag isn't supported by Linux kernel, return -1 and errno is set
> to EINVAL.

Thanks a lot for your information!  I will revise this in the next version.

Best Regards,
Huang, Ying