Re: [PATCH v1 2/2] ARM: dts: add Protonic MVT board

From: Oleksij Rempel
Date: Tue Dec 01 2020 - 02:11:21 EST


On Mon, Nov 30, 2020 at 10:22:38AM -0300, Fabio Estevam wrote:
> Hi Oleksij,
>
> On Mon, Nov 30, 2020 at 10:14 AM Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx> wrote:
>
> > +&ecspi1 {
> > + cs-gpios = <&gpio3 19 GPIO_ACTIVE_HIGH>;
>
> Shouldn't this be GPIO_ACTIVE_LOW instead?

ACK, it was fixed up by this code:
https://elixir.bootlin.com/linux/v5.10-rc6/source/drivers/gpio/gpiolib-of.c#L210

So, it was still working.

Thank you! I'll fix it.

Regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |