RE: [PATCH 3/3] edac: Supporting AST2400 and AST2600 edac driver

[Troy Lee]

Hi Stefan,

The driver was ported from latest ASPEED BSP, so I only test with ECC-on/off 
from u-boot and check if driver runs correctly.

The test doc you provided is very nice and detailed, I'll try to reproduce the 
injection test in v2 patch.

Thanks,
Troy Lee

> -----Original Message-----
> From: Stefan Schaeckeler (sschaeck) <sschaeck@xxxxxxxxx>
> Sent: Monday, November 30, 2020 5:16 PM
> To: Troy Lee <troy_lee@xxxxxxxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>;
> Joel Stanley <joel@xxxxxxxxx>; Andrew Jeffery <andrew@xxxxxxxx>; Borislav
> Petkov <bp@xxxxxxxxx>; Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>;
> Tony Luck <tony.luck@xxxxxxxxx>; James Morse <james.morse@xxxxxxx>;
> Robert Richter <rrichter@xxxxxxxxxxx>; open list:OPEN FIRMWARE AND
> FLATTENED DEVICE TREE BINDINGS <devicetree@xxxxxxxxxxxxxxx>; moderated
> list:ARM/ASPEED MACHINE SUPPORT <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>;
> moderated list:ARM/ASPEED MACHINE SUPPORT
> <linux-aspeed@xxxxxxxxxxxxxxxx>; open list <linux-kernel@xxxxxxxxxxxxxxx>;
> open list:EDAC-CORE <linux-edac@xxxxxxxxxxxxxxx>
> Cc: leetroy@xxxxxxxxx; Ryan Chen <ryan_chen@xxxxxxxxxxxxxx>; Stefan
> Schaeckeler <schaecsn@xxxxxxx>
> Subject: Re: [PATCH 3/3] edac: Supporting AST2400 and AST2600 edac driver
> 
> Hello Troy,
> 
> > Adding AST2400 and AST2600 edac driver support.
> >
> > Signed-off-by: Troy Lee <troy_lee@xxxxxxxxxxxxxx>
> > ---
> > drivers/edac/Kconfig       |   6 +-
> > drivers/edac/aspeed_edac.c | 114 +++++++++++++++++++++++++++++--------
> > 2 files changed, 94 insertions(+), 26 deletions(-)
> 
> Uh, there are quite some non-trivial changes. I'll have a look over the coming
> weekend.
> 
> Testing an edac driver comes with challenges. Did you test your code? If so,
> how?
> 
> That's how I was testing my original edac 2500 driver
> http://students.engr.scu.edu/~sschaeck/misc/aspeed-edac.html
> 
>  Stefan