Re: [PATCH] proc: add locking checks in proc_inode_is_dead

From: Oleg Nesterov
Date: Tue Dec 01 2020 - 07:37:30 EST


On 11/30, Eric W. Biederman wrote:
>
> Ouch!!!! Oleg I just looked the introduction of proc_inode_is_dead in
> d855a4b79f49 ("proc: don't (ab)use ->group_leader in proc_task_readdir()
> paths") introduced a ``regression''.
>
> Breaking the logic introduced in 7d8952440f40 ("[PATCH] procfs: Fix
> listing of /proc/NOT_A_TGID/task") to keep those directory listings not
> showing up.

Sorry, I don't understand...

Do you mean that "ls /proc/pid/task" can see an empty dir? Afaics this
was possible before d855a4b79f49 too.

Or what?

Oleg.