Re: [PATCH][next] gpio: ath79: Fix fall-through warning for Clang

[Bartosz Golaszewski]

On Thu, Nov 19, 2020 at 6:08 PM Gustavo A. R. Silva
<gustavoars@xxxxxxxxxx> wrote:
>
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a
> warning by explicitly adding a fallthrough pseudo-keyword to indicate
> that the code is intended to fall through to the next case.
>
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>
> ---
>  drivers/gpio/gpio-ath79.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-ath79.c b/drivers/gpio/gpio-ath79.c
> index d5359341cc6b..678ddd375891 100644
> --- a/drivers/gpio/gpio-ath79.c
> +++ b/drivers/gpio/gpio-ath79.c
> @@ -123,6 +123,7 @@ static int ath79_gpio_irq_set_type(struct irq_data *data,
>         switch (flow_type) {
>         case IRQ_TYPE_EDGE_RISING:
>                 polarity |= mask;
> +               fallthrough;
>         case IRQ_TYPE_EDGE_FALLING:
>         case IRQ_TYPE_EDGE_BOTH:
>                 break;
> --
> 2.27.0
>

Applied, thanks!

Bartosz