Re: [PATCH v5 16/16] scripts: kernel-doc: validate kernel-doc markup with the actual names

From: kernel test robot
Date: Tue Dec 01 2020 - 10:28:04 EST

Next
Previous
In reply
Next
Messages

Hi Mauro,

I love your patch!
[auto build test [cannot apply to [If your patch is And when submitting url: # apt-get install sparse
# sparse # If you fix the issue, Reported-by: kernel
All warnings (new
>> mm/vmscan.c:1614: * Isolating --
>> drivers/hv/vm --
drivers/rtc/class.c:326: >> drivers/rtc/class.c:326:
vim +1614 mm/vmscan.c

b4536f0c829c85 Michal Hocko f4b7e272b5c042 Andrey Ryabinin f46cdc387708fb Hugh Dickins f46cdc387708fb Hugh Dickins f46cdc387708fb Hugh Dickins ^1da177e4c3f41 Linus Torvalds ^1da177e4c3f41 Linus Torvalds ^1da177e4c3f41 Linus Torvalds ^1da177e4c3f41 Linus Torvalds ^1da177e4c3f41 Linus Torvalds ^1da177e4c3f41 Linus Torvalds f46cdc387708fb Hugh Dickins ^1da177e4c3f41 Linus Torvalds 791b48b642324c Minchan Kim 5dc35979e444b5 Konstantin Khlebnikov ^1da177e4c3f41 Linus Torvalds f626012db08b9e Hugh Dickins fe2c2a10666313 Rik van Riel 3cb9945179bd04 Konstantin Khlebnikov ^1da177e4c3f41 Linus Torvalds ^1da177e4c3f41 Linus Torvalds ^1da177e4c3f41 Linus Torvalds 69e05944af39fc Andrew Morton 5dc35979e444b5 Konstantin Khlebnikov fe2c2a10666313 Rik van Riel a9e7c39fa9fd90 Kirill Tkhai ^1da177e4c3f41 Linus Torvalds 75b00af77ed5b5 Hugh Dickins 69e05944af39fc Andrew Morton 599d0c954f91d0 Mel Gorman 7cc30fcfd2a894 Mel Gorman 3db65812d68883 Johannes Weiner 791b48b642324c Minchan Kim b2e18757f2c9d1 Mel Gorman a9e7c39fa9fd90 Kirill Tkhai ^1da177e4c3f41 Linus Torvalds 98879b3b9edc16 Yang Shi 791b48b642324c Minchan Kim 98879b3b9edc16 Yang Shi 5ad333eb66ff1e Andy Whitcroft 5ad333eb66ff1e Andy Whitcroft ^1da177e4c3f41 Linus Torvalds ^1da177e4c3f41 Linus Torvalds ^1da177e4c3f41 Linus Torvalds d8c6546b1aea84 Matthew Wilcox (Oracle 98879b3b9edc16 Yang Shi 98879b3b9edc16 Yang Shi b2e18757f2c9d1 Mel Gorman b2e18757f2c9d1 Mel Gorman 98879b3b9edc16 Yang Shi b2e18757f2c9d1 Mel Gorman b2e18757f2c9d1 Mel Gorman b2e18757f2c9d1 Mel Gorman 791b48b642324c Minchan Kim 791b48b642324c Minchan Kim 791b48b642324c Minchan Kim 791b48b642324c Minchan Kim 791b48b642324c Minchan Kim 98879b3b9edc16 Yang Shi 98879b3b9edc16 Yang Shi 98879b3b9edc16 Yang Shi 98879b3b9edc16 Yang Shi 791b48b642324c Minchan Kim 98879b3b9edc16 Yang Shi 0499e1a60797d4 Alex Shi 0499e1a60797d4 Alex Shi 0499e1a60797d4 Alex Shi 0499e1a60797d4 Alex Shi 0499e1a60797d4 Alex Shi ce8d4ae1c160d4 Alex Shi ce8d4ae1c160d4 Alex Shi ce8d4ae1c160d4 Alex Shi ce8d4ae1c160d4 Alex Shi ce8d4ae1c160d4 Alex Shi 0499e1a60797d4 Alex Shi 0499e1a60797d4 Alex Shi 0499e1a60797d4 Alex Shi 0499e1a60797d4 Alex Shi ce8d4ae1c160d4 Alex Shi ce8d4ae1c160d4 Alex Shi 0499e1a60797d4 Alex Shi ce8d4ae1c160d4 Alex Shi 0499e1a60797d4 Alex Shi 0499e1a60797d4 Alex Shi ce8d4ae1c160d4 Alex Shi ce8d4ae1c160d4 Alex Shi 599d0c954f91d0 Mel Gorman 599d0c954f91d0 Mel Gorman 5ad333eb66ff1e Andy Whitcroft ^1da177e4c3f41 Linus Torvalds ^1da177e4c3f41 Linus Torvalds b2e18757f2c9d1 Mel Gorman b2e18757f2c9d1 Mel Gorman b2e18757f2c9d1 Mel Gorman b2e18757f2c9d1 Mel Gorman b2e18757f2c9d1 Mel Gorman b2e18757f2c9d1 Mel Gorman b2e18757f2c9d1 Mel Gorman 7cc30fcfd2a894 Mel Gorman 7cc30fcfd2a894 Mel Gorman 7cc30fcfd2a894 Mel Gorman 3db65812d68883 Johannes Weiner 7cc30fcfd2a894 Mel Gorman 7cc30fcfd2a894 Mel Gorman 7cc30fcfd2a894 Mel Gorman 7cc30fcfd2a894 Mel Gorman 7cc30fcfd2a894 Mel Gorman 1265e3a69f1ea9 Michal Hocko 7cc30fcfd2a894 Mel Gorman 7cc30fcfd2a894 Mel Gorman 791b48b642324c Minchan Kim 1265e3a69f1ea9 Michal Hocko 791b48b642324c Minchan Kim b4536f0c829c85 Michal Hocko ^1da177e4c3f41 Linus Torvalds ^1da177e4c3f41 Linus Torvalds ^1da177e4c3f41 Linus Torvalds
---
0-DAY CI Kernel Attachment: Description: application/gzip message: Ard Biesheuvel: "Re: [PATCH 0/3] arm64:msr: Add MSR driver" message: Borislav Petkov: "Re: [PATCH 0/3] arm64:msr: Add MSR driver" to: kernel test robot: "Re: [PATCH v5 16/16] scripts: kernel-doc: validate kernel-doc markup with the actual names" in thread: Mauro Carvalho Chehab: "[PATCH v5 05/16] fs: fix kernel-doc markups" sorted by: [ date ] [ thread ] [ subject ] [ author ] Perhaps something to improve:
WARNING on next-20201201]
lwn/docs-next tip/sched/core hsi/for-next linus/master v5.10-rc6 v5.10-rc5 v5.10-rc4 v5.10-rc6]
applied to the wrong git tree, kindly drop us a note.
patch, we suggest to use '--base' as documented in
href="https://git-scm.com/docs/git-format-patch">https://git-scm.com/docs/git-format-patch]
href="https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/HSI-fix-a-kernel-doc-markup/20201201-210930">https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/HSI-fix-a-kernel-doc-markup/20201201-210930
82743c914853ef4b9247dbe6
-s021-20201201 (attached as .config)
(Debian 9.3.0-15) 9.3.0
version: v0.6.3-170-g3bc348f6-dirty
href="https://github.com/0day-ci/linux/commit/7c52ba119279c74e6c7e968e3fa7290bd0f3b837">https://github.com/0day-ci/linux/commit/7c52ba119279c74e6c7e968e3fa7290bd0f3b837
add linux-review https://github.com/0day-ci/linux
--no-tags linux-review Mauro-Carvalho-Chehab/HSI-fix-a-kernel-doc-markup/20201201-210930
7c52ba119279c74e6c7e968e3fa7290bd0f3b837
attached .config to linux build tree
C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64
kindly add following tag as appropriate
test robot <lkp@xxxxxxxxx>
ones prefixed by >>):
warning: wrong kernel-doc identifier on line:
page from the lruvec to fill in @dst list by nr_to_scan times.
bus_drv.c:1536: warning: expecting prototype for __vmbus_child_driver_register(). Prototype was for __vmbus_driver_register() instead
warning: Function parameter or member 'data' not described in 'devm_rtc_unregister_device'
warning: expecting prototype for rtc_device_unregister(). Prototype was for devm_rtc_unregister_device() instead
2017-01-10 1612
2019-03-05 1613 /**
2020-11-24 @1614 * Isolating page from the lruvec to fill in @dst list by nr_to_scan times.
2020-11-24 1615 *
2020-11-24 1616 * lruvec->lru_lock is heavily contended. Some of the functions that
2005-04-16 1617 * shrink the lists perform better by taking out a batch of pages
2005-04-16 1618 * and working on them outside the LRU lock.
2005-04-16 1619 *
2005-04-16 1620 * For pagecache intensive workloads, this function is the hottest
2005-04-16 1621 * spot in the kernel (apart from copy_*_user functions).
2005-04-16 1622 *
2020-11-24 1623 * Lru_lock must be held before calling this function.
2005-04-16 1624 *
2017-05-12 1625 * @nr_to_scan: The number of eligible pages to look through on the list.
2012-05-29 1626 * @lruvec: The LRU vector to pull pages from.
2005-04-16 1627 * @dst: The temp list to put pages on to.
2012-01-12 1628 * @nr_scanned: The number of pages that were scanned.
2012-03-21 1629 * @sc: The scan_control struct for this reclaim session
2012-05-29 1630 * @lru: LRU list id for isolating
2005-04-16 1631 *
2005-04-16 1632 * returns how many pages were moved onto *@dst.
2005-04-16 1633 */
2006-03-22 1634 static unsigned long isolate_lru_pages(unsigned long nr_to_scan,
2012-05-29 1635 struct lruvec *lruvec, struct list_head *dst,
2012-03-21 1636 unsigned long *nr_scanned, struct scan_control *sc,
2019-03-05 1637 enum lru_list lru)
2005-04-16 1638 {
2012-05-29 1639 struct list_head *src = &lruvec->lists[lru];
2006-03-22 1640 unsigned long nr_taken = 0;
2016-07-28 1641 unsigned long nr_zone_taken[MAX_NR_ZONES] = { 0 };
2016-07-28 1642 unsigned long nr_skipped[MAX_NR_ZONES] = { 0, };
2017-05-03 1643 unsigned long skipped = 0;
2017-05-12 1644 unsigned long scan, total_scan, nr_pages;
2016-07-28 1645 LIST_HEAD(pages_skipped);
2019-03-05 1646 isolate_mode_t mode = (sc->may_unmap ? 0 : ISOLATE_UNMAPPED);
2005-04-16 1647
2019-07-11 1648 total_scan = 0;
2017-05-12 1649 scan = 0;
2019-07-11 1650 while (scan < nr_to_scan && !list_empty(src)) {
2007-07-17 1651 struct page *page;
2007-07-17 1652
2005-04-16 1653 page = lru_to_page(src);
2005-04-16 1654 prefetchw_prev_lru_page(page, src, flags);
2005-04-16 1655
2019-09-23 1656) nr_pages = compound_nr(page);
2019-07-11 1657 total_scan += nr_pages;
2019-07-11 1658
2016-07-28 1659 if (page_zonenum(page) > sc->reclaim_idx) {
2016-07-28 1660 list_move(&page->lru, &pages_skipped);
2019-07-11 1661 nr_skipped[page_zonenum(page)] += nr_pages;
2016-07-28 1662 continue;
2016-07-28 1663 }
2016-07-28 1664
2017-05-12 1665 /*
2017-05-12 1666 * Do not count skipped pages because that makes the function
2017-05-12 1667 * return with no isolated pages if the LRU mostly contains
2017-05-12 1668 * ineligible pages. This causes the VM to not reclaim any
2017-05-12 1669 * pages, triggering a premature OOM.
2019-07-11 1670 *
2019-07-11 1671 * Account all tail pages of THP. This would not cause
2019-07-11 1672 * premature OOM since __isolate_lru_page() returns -EBUSY
2019-07-11 1673 * only when the page is being freed somewhere else.
2017-05-12 1674 */
2019-07-11 1675 scan += nr_pages;
2020-11-24 1676 if (!__isolate_lru_page_prepare(page, mode)) {
2020-11-24 1677 /* It is being freed elsewhere */
2020-11-24 1678 list_move(&page->lru, src);
2020-11-24 1679 continue;
2020-11-24 1680 }
2020-11-24 1681 /*
2020-11-24 1682 * Be careful not to clear PageLRU until after we're
2020-11-24 1683 * sure the page is not being freed elsewhere -- the
2020-11-24 1684 * page release code relies on it.
2020-11-24 1685 */
2020-11-24 1686 if (unlikely(!get_page_unless_zero(page))) {
2020-11-24 1687 list_move(&page->lru, src);
2020-11-24 1688 continue;
2020-11-24 1689 }
2020-11-24 1690
2020-11-24 1691 if (!TestClearPageLRU(page)) {
2020-11-24 1692 /* Another thread is already isolating this page */
2020-11-24 1693 put_page(page);
2020-11-24 1694 list_move(&page->lru, src);
2020-11-24 1695 continue;
2020-11-24 1696 }
2020-11-24 1697
2016-07-28 1698 nr_taken += nr_pages;
2016-07-28 1699 nr_zone_taken[page_zonenum(page)] += nr_pages;
2007-07-17 1700 list_move(&page->lru, dst);
2005-04-16 1701 }
2005-04-16 1702
2016-07-28 1703 /*
2016-07-28 1704 * Splice any skipped pages to the start of the LRU list. Note that
2016-07-28 1705 * this disrupts the LRU order when reclaiming for lower zones but
2016-07-28 1706 * we cannot splice to the tail. If we did then the SWAP_CLUSTER_MAX
2016-07-28 1707 * scanning would soon rescan the same pages to skip and put the
2016-07-28 1708 * system at risk of premature OOM.
2016-07-28 1709 */
2016-07-28 1710 if (!list_empty(&pages_skipped)) {
2016-07-28 1711 int zid;
2016-07-28 1712
2017-05-03 1713 list_splice(&pages_skipped, src);
2016-07-28 1714 for (zid = 0; zid < MAX_NR_ZONES; zid++) {
2016-07-28 1715 if (!nr_skipped[zid])
2016-07-28 1716 continue;
2016-07-28 1717
2016-07-28 1718 __count_zid_vm_events(PGSCAN_SKIP, zid, nr_skipped[zid]);
2017-02-22 1719 skipped += nr_skipped[zid];
2016-07-28 1720 }
2016-07-28 1721 }
2017-05-12 1722 *nr_scanned = total_scan;
2017-02-22 1723 trace_mm_vmscan_lru_isolate(sc->reclaim_idx, sc->order, nr_to_scan,
2017-05-12 1724 total_scan, skipped, nr_taken, mode, lru);
2017-01-10 1725 update_lru_sizes(lruvec, lru, nr_zone_taken);
2005-04-16 1726 return nr_taken;
2005-04-16 1727 }
2005-04-16 1728
Test Service, Intel Corporation
href="https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx">https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
>.config.gz

Next message: Ard Biesheuvel: "Re: [PATCH 0/3] arm64:msr: Add MSR driver"
Previous message: Borislav Petkov: "Re: [PATCH 0/3] arm64:msr: Add MSR driver"
In reply to: kernel test robot: "Re: [PATCH v5 16/16] scripts: kernel-doc: validate kernel-doc markup with the actual names"
Next in thread: Mauro Carvalho Chehab: "[PATCH v5 05/16] fs: fix kernel-doc markups"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]